[PATCH] D135427: [LTO] Make local linkage GlobalValue in non-prevailing COMDAT available_externally

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks for fixing regular LTO as well. Question on test change for that, and I had a couple questions on the ThinLTO test.



================
Comment at: llvm/lib/LTO/LTO.cpp:699
 
   // Additionally need to drop externally visible global values from the comdat
   // to available_externally, so that there aren't multiply defined linker
----------------
Update comment.


================
Comment at: llvm/test/LTO/Resolution/X86/comdat-mixed-lto.ll:19
 ; RUN: llvm-dis %t3.0.0.preopt.bc -o - | FileCheck %s
-; CHECK: define internal void @__cxx_global_var_init() section ".text.startup" {
+; CHECK: declare dso_local void @__cxx_global_var_init() section ".text.startup"
 ; CHECK: define available_externally dso_local void @testglobfunc() section ".text.startup" {
----------------
Any idea where this is getting dropped to a declaration before optimization?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135427/new/

https://reviews.llvm.org/D135427