[PATCH] D135483: [llvm][LLParser] Fix issue with forward-referenced dso_local_equivalent globals
Leonard Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 7 15:01:49 PDT 2022
leonardchan added a comment.
In D135483#3844023 <https://reviews.llvm.org/D135483#3844023>, @nikic wrote:
> This seems to add some non-trivial complexity for something that is only relevant for typed pointers. Why do you need this at this point in time?
I'm writing tests to get [thin]lto to support relative vtables (D134320 <https://reviews.llvm.org/D134320>). One of the recommendations for ensuring thinlto support was writing equivalent tests to `llvm/test/ThinLTO/X86/devirt.ll` but using the relative vtable layout which uses `dso_local_equivalent`, so I'm essentially reusing a lot of what's in that file for testing RV. That is, for each test case I see for a regular vtable I'll test for a relative vtable. It just so happens that test and a lot of the whole program devirtualization tests in general still use typed pointers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135483/new/
https://reviews.llvm.org/D135483
More information about the llvm-commits
mailing list