[PATCH] D134557: [BranchRelaxation] Fall through only if block has no unconditional branches

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 added a comment.

In D134557#3843869 <https://reviews.llvm.org/D134557#3843869>, @efriedma wrote:

>> analyzeBranch returns false when it is able to infer the terminators of the basic block
>
> Right... and when it fails to analyze (i.e. returns true), you assume there is no fallthrough.  I don't think that's a safe assumption.

Two possiblities: (1) there may be a known control barrier in the end of this block or, (2) the barrier may be predicated during IfConversion. In either case, fallthrough should be allowed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134557/new/

https://reviews.llvm.org/D134557