[llvm] c966da3 - [opt] Remove legacy -print-dom-info pass

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 13:50:43 PDT 2022


Author: Arthur Eubanks
Date: 2022-10-07T13:50:16-07:00
New Revision: c966da35df067bcef9ed1ae94442c55db0f3147a

URL: https://github.com/llvm/llvm-project/commit/c966da35df067bcef9ed1ae94442c55db0f3147a
DIFF: https://github.com/llvm/llvm-project/commit/c966da35df067bcef9ed1ae94442c55db0f3147a.diff

LOG: [opt] Remove legacy -print-dom-info pass

This was specific to `opt` for some reason.
There's already a new pass manager pass `print<domtree>` which does the same.

Added: 
    

Modified: 
    llvm/docs/Passes.rst
    llvm/tools/opt/CMakeLists.txt
    llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn

Removed: 
    llvm/tools/opt/GraphPrinters.cpp


################################################################################
diff  --git a/llvm/docs/Passes.rst b/llvm/docs/Passes.rst
index 7c0666992e8f5..ea5f74dc45c93 100644
--- a/llvm/docs/Passes.rst
+++ b/llvm/docs/Passes.rst
@@ -296,11 +296,6 @@ standard error in a human-readable form.
 This pass, only available in ``opt``, printsthe SCCs of each function CFG to
 standard error in a human-readable fom.
 
-``-print-dom-info``: Dominator Info Printer
--------------------------------------------
-
-Dominator Info Printer.
-
 ``-print-externalfnconstants``: Print external fn callsites passed constants
 ----------------------------------------------------------------------------
 

diff  --git a/llvm/tools/opt/CMakeLists.txt b/llvm/tools/opt/CMakeLists.txt
index bbba70745813d..48b090b37639e 100644
--- a/llvm/tools/opt/CMakeLists.txt
+++ b/llvm/tools/opt/CMakeLists.txt
@@ -30,7 +30,6 @@ set(LLVM_LINK_COMPONENTS
 add_llvm_tool(opt
   AnalysisWrappers.cpp
   BreakpointPrinter.cpp
-  GraphPrinters.cpp
   NewPMDriver.cpp
   PrintSCC.cpp
   opt.cpp

diff  --git a/llvm/tools/opt/GraphPrinters.cpp b/llvm/tools/opt/GraphPrinters.cpp
deleted file mode 100644
index 611fb20513c96..0000000000000
--- a/llvm/tools/opt/GraphPrinters.cpp
+++ /dev/null
@@ -1,45 +0,0 @@
-//===- GraphPrinters.cpp - DOT printers for various graph types -----------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-//
-// This file defines several printers for various 
diff erent types of graphs used
-// by the LLVM infrastructure.  It uses the generic graph interface to convert
-// the graph into a .dot graph.  These graphs can then be processed with the
-// "dot" tool to convert them to postscript or some other suitable format.
-//
-//===----------------------------------------------------------------------===//
-
-#include "llvm/IR/Dominators.h"
-#include "llvm/Pass.h"
-
-using namespace llvm;
-
-//===----------------------------------------------------------------------===//
-//                            DomInfoPrinter Pass
-//===----------------------------------------------------------------------===//
-
-namespace {
-  class DomInfoPrinter : public FunctionPass {
-  public:
-    static char ID; // Pass identification, replacement for typeid
-    DomInfoPrinter() : FunctionPass(ID) {}
-
-    void getAnalysisUsage(AnalysisUsage &AU) const override {
-      AU.setPreservesAll();
-      AU.addRequired<DominatorTreeWrapperPass>();
-    }
-
-    bool runOnFunction(Function &F) override {
-      getAnalysis<DominatorTreeWrapperPass>().print(dbgs());
-      return false;
-    }
-  };
-}
-
-char DomInfoPrinter::ID = 0;
-static RegisterPass<DomInfoPrinter>
-DIP("print-dom-info", "Dominator Info Printer", true, true);

diff  --git a/llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn b/llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn
index 64c05a733dd09..9ad220d767280 100644
--- a/llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/tools/opt/BUILD.gn
@@ -22,7 +22,6 @@ executable("opt") {
   sources = [
     "AnalysisWrappers.cpp",
     "BreakpointPrinter.cpp",
-    "GraphPrinters.cpp",
     "NewPMDriver.cpp",
     "PrintSCC.cpp",
     "opt.cpp",


        


More information about the llvm-commits mailing list