[PATCH] D135415: [GlobalISel] Add commutative matchers for compares.

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:690
+template <typename Pred, typename LHS, typename RHS>
+inline CompareOp_match<Pred, LHS, RHS, TargetOpcode::G_ICMP, true>
+m_c_GICmp(const Pred &P, const LHS &L, const RHS &R) {
----------------
You could put `[[nodiscard]]` here.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:705
+template <typename Pred, typename LHS, typename RHS>
+inline CompareOp_match<Pred, LHS, RHS, TargetOpcode::G_FCMP, true>
+m_c_GFCmp(const Pred &P, const LHS &L, const RHS &R) {
----------------
You could  put `[[nodiscard]]` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135415/new/

https://reviews.llvm.org/D135415