[PATCH] D134614: [SCEV] Support clearing Block/LoopDispositions for a single value.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:8418
+
+  LoopDispositions.erase(S);
 }
----------------
nikic wrote:
> This line shouldn't be there?
Yep, that was left over from earlier versions, removed, thanks!


================
Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:92
 
+      bool InstrMoved = false;
       if (Instruction *I = dyn_cast<Instruction>(incoming)) {
----------------
nikic wrote:
> Declaration can be moved inside the if.
Moved, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134614/new/

https://reviews.llvm.org/D134614