[PATCH] D134725: [ADT] Add support for more formats in APFixedPoint

Fri Oct 7 07:03:14 PDT 2022

uabelho added a comment.

In D134725#3842654 <https://reviews.llvm.org/D134725#3842654>, @uabelho wrote:

> Hi,
> Just a heads-up that we see miscompiles with this patch for our out-of-tree target.
> It might very well be something in our code that is broken, just thought I'd mention it in case someone else have problems too.
> I'll try to debug our problems and see what's up.

I don't have any details about how, but it's a cast from a negative fixed point number to an integer that goes wrong now.
So -0.1r is turned into -1 instead of the expected value 0.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134725/new/

https://reviews.llvm.org/D134725