[PATCH] D135435: [Attributor] Use ConstantFoldLoadFromConst()

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 06:29:59 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, thanks! Wrt. regression problem see below.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:245
+
+  return nullptr;
 }
----------------
You exposed a bug, the above should be correct and avoid the regression. If we load any bytes from a null value we get null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135435/new/

https://reviews.llvm.org/D135435



More information about the llvm-commits mailing list