[PATCH] D135166: [DebugInfo] getMergedLocation: Maintain the line number if they match

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:122
     if (!S && L) {
+      Line = Col = 0;
       S = L->getScope();
----------------
dblaikie wrote:
> Could you walk me through why the line/col get set to zero at this point? I'd maybe have thought they should get set to the line/col of the InlinedAt location? 
It was my mistake. Your comment made me have second thoughts about that change.

I added some extra unit-tests for the cases where the InlinedAt line/column is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135166/new/

https://reviews.llvm.org/D135166