[PATCH] D135430: [llvm-objdump] Support nonzero section addresses in addSymbolizer
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 7 01:12:56 PDT 2022
Pierre-vh created this revision.
Pierre-vh added reviewers: tpr, MaskRay, scott.linder.
Herald added subscribers: kosarev, StephenFan, kerbowa, jvesely.
Herald added a reviewer: jhenderson.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
The previous calculations seem to have assumed that the section address would be zero.
This is true for relocatable object files, but certainly not for linked files like shared libraries.
Fixed the calculations to make them identical to the "real" `getInstruction` call below & added a regression test.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135430
Files:
llvm/test/tools/llvm-objdump/AMDGPU/elf-disassemble-symbolize-operands.yaml
llvm/tools/llvm-objdump/llvm-objdump.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135430.465996.patch
Type: text/x-patch
Size: 4209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221007/444f96c3/attachment.bin>
More information about the llvm-commits
mailing list