[PATCH] D135354: [LoopPredication] Insert assumes of conditions of predicated guards

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Do you have an exact motivation test where another pass fails to deduct facts from the new condition?



================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:831
+  }
   RecursivelyDeleteTriviallyDeadInstructions(OldCond, nullptr /* TLI */, MSSAU);
 
----------------
It's no longer dead.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:846
+  if (!parseWidenableBranch(BI, Cond, WC, IfTrueBB, IfFalseBB))
+    llvm_unreachable("Must be able to parse widenable branch");
+
----------------
Better use assert for it.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:866
+  }
   RecursivelyDeleteTriviallyDeadInstructions(OldCond, nullptr /* TLI */, MSSAU);
   assert(isGuardAsWidenableBranch(BI) &&
----------------
Same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135354/new/

https://reviews.llvm.org/D135354