[PATCH] D135419: [readobj] Make JSON output consistent for Other flags

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test:40-41
 # LLVM1-NEXT:     Type: None (0x0)
-# LLVM1-NEXT:     Other: 0
+# LLVM1-NEXT:     Other [ (0x0)
+# LLVM1-NEXT:     ]
 # LLVM1-NEXT:     Section: Undefined (0x0)
----------------
phosek wrote:
> Can we modify `https://github.com/llvm/llvm-project/blob/f4e8f44811e25fd5547d879aafafd621386eb927/llvm/include/llvm/Support/ScopedPrinter.h#L444` to avoid printing `\n` and `startLine()` when `Flags` are empty so we end up with `Other [ (0x0) ]` for this case.
Yeah, that's a good suggestion. I'll look into handling that case more gracefully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135419/new/

https://reviews.llvm.org/D135419