[PATCH] D135190: [DirectX backend] Add analysis to collect DXILResources

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

A few last really nitpicky whitespace issues. Otherwise looks good.



================
Comment at: llvm/lib/Target/DirectX/DXILResource.cpp:347
 }
+void Resources::print(raw_ostream &O) const {
+  O << ";\n"
----------------
nit: please add a blank line between functions.


================
Comment at: llvm/lib/Target/DirectX/DXILResourceAnalysis.cpp:27
+}
+AnalysisKey DXILResourceAnalysis::Key;
+
----------------
nit: blank line here too


================
Comment at: llvm/lib/Target/DirectX/DXILResourceAnalysis.cpp:46
+}
+DXILResourceWrapper::DXILResourceWrapper() : ModulePass(ID) {}
+
----------------
nit: blank line here too


================
Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:31
   StringRef getPassName() const override { return "DXIL Metadata Emit"; }
-
+  void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.setPreservesAll();
----------------
nit: blank lines before and after this function too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135190/new/

https://reviews.llvm.org/D135190