[PATCH] D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata
Matthew Voss via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 6 13:35:09 PDT 2022
ormris added inline comments.
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp:58
+
+ Visited.insert(MD);
+ }
----------------
aeubanks wrote:
> typically we check visited at the top of the loop, rather than when adding, because we may add something to the queue multiple times before visiting it, and we end up processing something multiple times
> typically we check visited at the top of the loop, rather than when adding, because we may add something to the queue multiple times before visiting it, and we end up processing something multiple times
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132077/new/
https://reviews.llvm.org/D132077
More information about the llvm-commits
mailing list