[PATCH] D135237: [llvm-reduce] Remove debug metadata elements

Thu Oct 6 13:06:29 PDT 2022

ellis added a comment.

In D135237#3840909 <https://reviews.llvm.org/D135237#3840909>, @aeubanks wrote:

> sorry to be late to reviewing this, but I think this is overly aggressive. I see verifier failures like `scope must have two or three operands` after this patch.
>
> https://reviews.llvm.org/D132077 was in the process of being reviewed and basically does this but more targeted with a specific focus on not creating verifier failures (since that's the direction we'd like to take llvm-reduce, not producing verifier failures since that slows down reduction a lot and dumps a lot of output). could we revert this and use the other patch?

Oh sorry I was not aware of D132077 <https://reviews.llvm.org/D132077>. After a quick look at the summary it looks very similar to this diff. Since D132077 <https://reviews.llvm.org/D132077> is a better direction, I'll revert my diff. Thanks for letting me know!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135237/new/

https://reviews.llvm.org/D135237