[PATCH] D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

lg with comments addressed, but we need to figure out what to do with https://reviews.llvm.org/D135237. I think that one is overly aggressive, I'll ask if we can use this patch instead



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp:1
+//===- ReduceMetadata.cpp - Specialized Delta Pass ------------------------===//
+//
----------------
headers need updating


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp:58
+
+    Visited.insert(MD);
+  }
----------------
typically we check visited at the top of the loop, rather than when adding, because we may add something to the queue multiple times before visiting it, and we end up processing something multiple times


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp:45
+    if (DINode *DIM = dyn_cast_or_null<DINode>(MD)) {
+        // Scan operands and record attached tuples
+        for (size_t I = 0; I < DIM->getNumOperands(); ++I)
----------------
ormris wrote:
> aeubanks wrote:
> > some indentation weirdness, `git clang-format`?
> This is what clang-format outputs. Happy to make it look cleaner, but I couldn't see a way to improve it.
if you delete one of the leading spaces before the comment, the whole block will be properly formatted by clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132077/new/

https://reviews.llvm.org/D132077