[PATCH] D135387: [LoopPeel] Allow to bypass profitability checks. NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 12:11:43 PDT 2022


nikic added a comment.

As the comment indicates, this is not entirely a profitability check: The current peeling code does not correctly update branch weights if this condition is not satisfied. D134803 <https://reviews.llvm.org/D134803> implements the necessary support and removes this check entirely.

I also don't get how you plan to use this flag -- after all peelLoop() also contains a canPeel() assertion, so you wouldn't be able to call to call it anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135387/new/

https://reviews.llvm.org/D135387



More information about the llvm-commits mailing list