[PATCH] D127472: [llvm-driver] Add lld

Thu Oct 6 12:10:59 PDT 2022

abrachet marked an inline comment as done.
abrachet added a comment.

In D127472#3575182 <https://reviews.llvm.org/D127472#3575182>, @MaskRay wrote:

> Please add `-DLLVM_TOOL_LLVM_DRIVER_BUILD=on` to the summary. `[llvm-driver]` isn't clear.

Done

> Note: by using this, we lose the property to make clang and lld separately profile-guided optimized.

Yeah, that's a good observation I hadn't thought about. Likely the way clang and lld utilize libObject is very different for example. I can look into adding something along the lines of a `LLVM_DRIVER_EXCLUDE_TOOLS` list so it can chosen if some tools should be omitted.

> Since you work at Google, can I request that you fix `llvm-project-overlay/lld/BUILD.bazel` similar to `llvm-project-overlay/clang/BUILD.bazel` `clang_main`?
> Otherwise it would cause some integration trouble...

Done

In D127472#3610252 <https://reviews.llvm.org/D127472#3610252>, @abrachet wrote:

> I was considering holding off on this patch till after D127800 <https://reviews.llvm.org/D127800> so that the diff would be simpler there. Or would you rather move ahead here first?

It actually didn't complicate things at all...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127472/new/

https://reviews.llvm.org/D127472