[PATCH] D135173: Detect Visual Studio in Windows packaging script

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 11:09:15 PDT 2022


thieta added a comment.

Vswhere has a million options so I bet we can get it to find whatever we want. What I like about that approach is that it is not relying on hardcoded paths and it will work on any setup.

I think if possible we should do this:

1. if we are in a dev shell - use that
2. if the user pass --vs2022 - try to find latest vs22 installed (exclude preview if possible)
3. find latest non-preview version installed.
4. no vswhere or no VS installed - error out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135173/new/

https://reviews.llvm.org/D135173



More information about the llvm-commits mailing list