[PATCH] D135108: [WIP][llvm-driver] Fix clang -fno-integrated-cc1 when invoked from the llvm driver

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked an inline comment as done.
abrachet added inline comments.


================
Comment at: llvm/lib/Support/LLVMDriver.cpp:11
+
+bool IsLLVMDriver = false;
+
----------------
phosek wrote:
> I'd prefer if this variable was a constant because there's no reason why should ever be changed at runtime.
> 
> Rather than defining it here, could we instead define it in `llvm/tools/llvm-driver/llvm-driver.cpp` and `llvm/cmake/driver-template.cpp.in` as constant that's initialized to `true` and `false` respectively.
Nice, I like that, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135108/new/

https://reviews.llvm.org/D135108