[PATCH] D135371: Remove PlaceSafepoints pass

[Philip Reames via Phabricator via llvm-commits]

reames created this revision.
Herald added subscribers: mgrang, bollu, hiraditya, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added a project: LLVM.

This patch was added way back in the beginning of the work which became the statepoint infrastructure.  The idea was that safepoints could be inserted late in the optimization pipeline.  This is true if the only concern is garbage collection, but this approach turned out to be incompatible with the requirement to also support deoptimization at safepoints.

In theory, this pass would still be quite useful for an AOT compiled language which wants to support garbage collection, but we have no known users, and haven't for over 5 years.  Time to remove unused code.  If someone wants to use this, restoring it would not be hard.  The immediate motivation for removal is that this is one of the last passes remaining which hasn't been ported to the new pass manager and the (straight forward) work to do so is not justified for unused code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135371

Files:
  llvm/docs/GarbageCollection.rst
  llvm/docs/Statepoints.rst
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/Transforms/Scalar.h
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Scalar/PlaceSafepoints.cpp
  llvm/lib/Transforms/Scalar/Scalar.cpp
  llvm/test/Transforms/PlaceSafepoints/basic.ll
  llvm/test/Transforms/PlaceSafepoints/call-in-loop.ll
  llvm/test/Transforms/PlaceSafepoints/finite-loops.ll
  llvm/test/Transforms/PlaceSafepoints/libcall.ll
  llvm/test/Transforms/PlaceSafepoints/memset.ll
  llvm/test/Transforms/PlaceSafepoints/no-statepoints.ll
  llvm/test/Transforms/PlaceSafepoints/split-backedge.ll
  llvm/test/Transforms/PlaceSafepoints/statepoint-coreclr.ll
  llvm/test/Transforms/PlaceSafepoints/statepoint-frameescape.ll
  llvm/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135371.465760.patch
Type: text/x-patch
Size: 48734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221006/af076083/attachment.bin>