[PATCH] D134064: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

This set of tests LGTM, but they are still not enough to provide coverage for the proposed code patch, so we need to add a few more tests. If the pattern-matching uses ValueTracking calls (`isKnownNonZero` and `haveNoCommonBitsSet`) then we should have some tests with non-constant select operands to exercise that. You can look at the implementations of those calls and reverse engineer tests that will match with variable operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134064/new/

https://reviews.llvm.org/D134064