[PATCH] D134418: [AMDGPU] Improve ISel for v_bfi instructions.

Thomas Symalla via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 05:11:09 PDT 2022


tsymalla abandoned this revision.
tsymalla added a comment.

In this specific example, `visitMaskedMerge` for xor InstCombine tries to combine the xor, and, xor pattern as long as both xor instruction use the same operand. This works for the first xor, and, xor sequence, but changes the IR in such way that the second xor, and, xor sequence (which depends on the result of the first one) cannot be matched anymore even if it could before. This prevents the second v_bfi from being generated.
I will abandon this change and try to generate the canonical form earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134418/new/

https://reviews.llvm.org/D134418



More information about the llvm-commits mailing list