[PATCH] D135255: Introduce options for Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:44
+    echo choose one or several variants from: --x86 --x64
+    exit /b 1
+)
----------------
pbo-linaro wrote:
> hans wrote:
> > Is it intentional that for missing version we `goto usage`, but for missing build variant we just print and exit?
> That was chosen to avoid showing full help in this case (user will focus on latest lines, which is not the error).
> Tried adding a separator, like "=======================", but it's not visual enough to focus attention IMHO.
To be more clear regarding your question, workflow for user will be:
1- try the script without args => show usage
2- "Oh, version is required" => call script with --version XXX
3- Instead of printing full help (user already saw it), just tell me is missing an arch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135255/new/

https://reviews.llvm.org/D135255