[PATCH] D135255: Introduce options for Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked an inline comment as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:41
+
+if "%x64%" == "" if "%x86%" == "" (
+    echo nothing to build!
----------------
hans wrote:
> The `if .. if` syntax looks funny. Is this a batch thing?
batch IF does not have "and" operator.
https://stackoverflow.com/questions/2143187/logical-operators-and-or-in-dos-batch

I agree that's funny. If someone has a better syntax, I'll take it happily :)


================
Comment at: llvm/utils/release/build_llvm_release.bat:44
+    echo choose one or several variants from: --x86 --x64
+    exit /b 1
+)
----------------
hans wrote:
> Is it intentional that for missing version we `goto usage`, but for missing build variant we just print and exit?
That was chosen to avoid showing full help in this case (user will focus on latest lines, which is not the error).
Tried adding a separator, like "=======================", but it's not visual enough to focus attention IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135255/new/

https://reviews.llvm.org/D135255