[PATCH] D109958: [LoopFlatten] Enable it by default
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 6 03:49:15 PDT 2022
SjoerdMeijer added a comment.
In D109958#3839132 <https://reviews.llvm.org/D109958#3839132>, @craig.topper wrote:
> I think clang/test/Profile/misexpect-switch-only-default-case.c may get a failure with -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON which enables verify-scev if this pass is enabled by default.
>
> I think the pass needs to call SE->forgetLoopDispositions() when it flattens loops. I don't know exactly what LoopDispositions are in SCEV so hopefully someone else can take a look.
Thanks for catching and reporting this!
Adding `SE->forgetLoopDispositions()` indeed fixes that test, and passes initial testing, but I will do some more testing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109958/new/
https://reviews.llvm.org/D109958
More information about the llvm-commits
mailing list