[PATCH] D135255: Introduce options for Windows packaging script

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Basically lgtm, just some nitty comments.



================
Comment at: llvm/utils/release/build_llvm_release.bat:20
+echo.
+echo Example: build_llvm_release.bat --version 15.0.0 --x64
 exit /b 1
----------------
Maybe we should add `--x86` to the example too, just to highlight that more than one can be used?


================
Comment at: llvm/utils/release/build_llvm_release.bat:41
+
+if "%x64%" == "" if "%x86%" == "" (
+    echo nothing to build!
----------------
The `if .. if` syntax looks funny. Is this a batch thing?


================
Comment at: llvm/utils/release/build_llvm_release.bat:44
+    echo choose one or several variants from: --x86 --x64
+    exit /b 1
+)
----------------
Is it intentional that for missing version we `goto usage`, but for missing build variant we just print and exit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135255/new/

https://reviews.llvm.org/D135255