[PATCH] D135255: Introduce options for Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro added a comment.

I'm more in favor of less magic, and more explicit.
For giving more context, a lot of projects are relying on platform detection to compile things for Windows on Arm, and frankly, it's a pain.
Most are using python (platform.machine()), which changes depending if you execute an x64 or arm64 interpreter.
So, depending on which python you install, you're not targeting exactly what you expect.
The env var PROCESSOR_ARCHITECTURE can be different too, depending if you use powershell.exe, or cmd.exe. Nice.

Being able to say clearly "this is what is expected" is a good property.
When requesting this from user, IMHO, the *important* is that the script stops (and fails) and asks you exactly what you want:

  43 echo choose one or several variants from: --x86 --x64
  44 exit /b 1

So, you don't have to dig in script internals to understand what is done/expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135255/new/

https://reviews.llvm.org/D135255