[PATCH] D135173: Detect Visual Studio in Windows packaging script

Thu Oct 6 00:38:35 PDT 2022

thieta accepted this revision.
thieta added inline comments.

================
Comment at: llvm/utils/release/build_llvm_release.bat:56
+set vsdevcmd=
+set vs_2019_prefix=C:\Program Files (x86)\Microsoft Visual Studio\2019
+:: try potential activated visual studio, then 2019, with different editions
----------------
pbo-linaro wrote:
> thieta wrote:
> > pbo-linaro wrote:
> > > thieta wrote:
> > > > I wonder if we should allow 2022 here as well. At least with a switch or something. LLVM should work with it and I don't see any reason for users to install 2019 just for this?
> > > I'm 100% ok to select VS2022 by default (and fallback to 2019 if needed).
> > > Do you know if everything is building fine under that newer version?
> > Yeah we build with 2022 and haven't seen any problems. Maybe after your patch with switches we could introduce a switch to force a VS version if more than one is installed?
> Great. Is that ok for you to introduce this after that patch? Or I can edit, and add 2022 selection in this one.
I think it's fine doing it like this now and then adding a new commit that adds vs2022 support.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135173/new/

https://reviews.llvm.org/D135173