[PATCH] D135255: Introduce options for Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked an inline comment as done.
pbo-linaro added a comment.

In D135255#3839224 <https://reviews.llvm.org/D135255#3839224>, @thieta wrote:

> I wonder if we shouldn't just build both archs if nothing is specified to keep the old behavior.

The first goal of all those patches, beyond cleanup, is to add arm64 support to this script.
Alas, it can't be run from an x64 machine (build yes, but not tests).
I think making explicit which targets you want is a better choice than enabling only two of the three targets.

I can still change to:

- nothing: x86 + x64
- add arm64 later, but not activated by default

Depends on your taste, I'm open to what you prefer :)



================
Comment at: llvm/utils/release/build_llvm_release.bat:13
+echo Options:
+echo --revision: [required] revision to build
+echo --help: display this help
----------------
thieta wrote:
> Not sure I like `--revision` here. I would probably use `--version` instead.
I'll switch back to version


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135255/new/

https://reviews.llvm.org/D135255