[PATCH] D130466: [LICM] - Add option to force thread model single

Wed Oct 5 23:50:56 PDT 2022

gsocshubham added a comment.

In D130466#3824014 <https://reviews.llvm.org/D130466#3824014>, @nikic wrote:

> Can you please run the test cases through `-sroa` (as in, commit the test case with SROA applied, not add it to the RUN line)? The current tests contain unnecessary alloca+load/store+lifetime.start/end.

I have run -sroa and shared respective dumps.

Please let me know if you need any other changes in this current patch.

================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:116
+                                  cl::init(false),
+                                  cl::desc("Allow data races in LICM pass"));
+
----------------
gsocshubham wrote:
> nikic wrote:
> > Update description to match new option name?
> Done.
@nikic - Updated the description.

================
Comment at: llvm/test/Transforms/LICM/promote-sink-store-arg.ll:98
+for.inc:                                          ; preds = %for.body
+  %i4 = load i32, ptr %i, align 4
+  %inc = add nsw i32 %i4, 1
----------------
gsocshubham wrote:
> arsenm wrote:
> > How is the threadedness relevant in a case that doesn't use atomic loads and stores? 
> I have added a new test named - promote-sink-atomic-store-arg.ll below which contains atomic store.
> 
> Let me know WDYT of the new test.
@arsenm - Any thoughts on above?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130466/new/

https://reviews.llvm.org/D130466