[llvm] a946eb1 - ReduceOperands: Do not crash on vector of pointer types

[Matthias Braun via llvm-commits]

Author: Matthias Braun
Date: 2022-10-05T15:04:32-07:00
New Revision: a946eb160a45d1761536b8782a6de8afae87cc51

URL: https://github.com/llvm/llvm-project/commit/a946eb160a45d1761536b8782a6de8afae87cc51
DIFF: https://github.com/llvm/llvm-project/commit/a946eb160a45d1761536b8782a6de8afae87cc51.diff

LOG: ReduceOperands: Do not crash on vector of pointer types

Avoid crash in `reduceOperandsOneDeltaPass` function for operands with
vector of pointer type.

While on it add a `reduce-operands-ptr.ll` test in the spirit of the
existing `reduce-operands-int.ll`/`reduce-operands-fp.ll` tests.

Differential Revision: https://reviews.llvm.org/D135307

Added: 
    llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll

Modified: 
    llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll b/llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll
new file mode 100644
index 0000000000000..3e163b30f6b38
--- /dev/null
+++ b/llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll
@@ -0,0 +1,33 @@
+; Test that llvm-reduce can reduce pointer operands
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-one --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ONE %s < %t
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-zero --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ZERO %s < %t
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ZERO %s < %t
+
+; CHECK-LABEL: define void @foo(
+
+; ONE: load i32, ptr %a0
+; ONE: load i32, ptr @g
+; ONE: extractelement <4 x ptr> <ptr @g, ptr null, ptr @g, ptr @g>, i32 11
+
+; ZERO: load i32, ptr null
+; ZERO: load i32, ptr null
+; ZERO: extractelement <4 x ptr> zeroinitializer, i32 11
+
+ at g = global i32 0
+
+define void @foo(ptr %a0) {
+  ; CHECK-INTERESTINGNESS: load i32
+  %v0 = load i32, ptr %a0
+  ; CHECK-INTERESTINGNESS: load i32
+  %v1 = load i32, ptr @g
+
+  ; CHECK-INTERESTINGNESS: extractelement{{.*}}i32 11
+  %v2 = extractelement <4 x ptr> <ptr @g, ptr null, ptr @g, ptr @g>, i32 11
+
+  ret void
+}

diff  --git a/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp b/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
index f2e2a0b34c5c8..0dc2a348981c9 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
+++ b/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
@@ -92,12 +92,16 @@ void llvm::reduceOperandsOneDeltaPass(TestRunner &Test) {
       if (isOne(Op) || isZero(Op) || isZeroOrOneFP(Op))
         return nullptr;
 
-      if (auto *IntTy = dyn_cast<IntegerType>(VT->getElementType()))
-        return ConstantVector::getSplat(VT->getElementCount(),
-                                        ConstantInt::get(IntTy, 1));
-
-      return ConstantVector::getSplat(
-          VT->getElementCount(), ConstantFP::get(VT->getElementType(), 1.0));
+      Type *ElementType = VT->getElementType();
+      Constant *C;
+      if (ElementType->isFloatingPointTy()) {
+        C = ConstantFP::get(ElementType, 1.0);
+      } else if (IntegerType *IntTy = dyn_cast<IntegerType>(ElementType)) {
+        C = ConstantInt::get(IntTy, 1);
+      } else {
+        return nullptr;
+      }
+      return ConstantVector::getSplat(VT->getElementCount(), C);
     }
 
     return nullptr;