[PATCH] D135237: [llvm-reduce] Remove debug metadata elements

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Seems pretty good to me.



================
Comment at: llvm/test/tools/llvm-reduce/remove-debug-info-nodes.ll:15-18
+; CHECK-INTERESTINGNESS-DAG: !{{DIGlobalVariable}}(
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "A"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "B"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "C"
----------------
ellis wrote:
> dblaikie wrote:
> > The `DILocalVariable`s don't need `{{``}}` do they?
> Hmm I originally added this because I didn't want these lines to match themselves. But I guess after the first iteration the comments will be removed and they wont' match themselves anymore.
> 
> The tests pass without them so I'll remove them.
oh, fair point - if that's a common stylistic thing done in other llvm-reduce tests, I don't mind it here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135237/new/

https://reviews.llvm.org/D135237