[PATCH] D135307: llvm-reduce: Do not crash on operands with vector of pointer type

[Matthias Braun via Phabricator via llvm-commits]

MatzeB created this revision.
MatzeB added reviewers: swamulism, aeubanks, frasercrmck.
Herald added subscribers: modimo, wenlei, mcrosier.
Herald added a project: All.
MatzeB requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Avoid crash in `reduceOperandsOneDeltaPass` function for operands with
vector of pointer type.

While on it add a `reduce-operands-ptr.ll` test in the spirit of the
existing `reduce-operands-int.ll`/`reduce-operands-fp.ll` tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135307

Files:
  llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll
  llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp


Index: llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
===================================================================
--- llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
+++ llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
@@ -92,12 +92,16 @@
       if (isOne(Op) || isZero(Op) || isZeroOrOneFP(Op))
         return nullptr;
 
-      if (auto *IntTy = dyn_cast<IntegerType>(VT->getElementType()))
-        return ConstantVector::getSplat(VT->getElementCount(),
-                                        ConstantInt::get(IntTy, 1));
-
-      return ConstantVector::getSplat(
-          VT->getElementCount(), ConstantFP::get(VT->getElementType(), 1.0));
+      Type *ElementType = VT->getElementType();
+      Constant *C;
+      if (ElementType->isFloatingPointTy()) {
+        C = ConstantFP::get(ElementType, 1.0);
+      } else if (IntegerType *IntTy = dyn_cast<IntegerType>(ElementType)) {
+        C = ConstantInt::get(IntTy, 1);
+      } else {
+        return nullptr;
+      }
+      return ConstantVector::getSplat(VT->getElementCount(), C);
     }
 
     return nullptr;
Index: llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-reduce/reduce-operands-ptr.ll
@@ -0,0 +1,33 @@
+; Test that llvm-reduce can reduce pointer operands
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-one --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ONE %s < %t
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-zero --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ZERO %s < %t
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK,ZERO %s < %t
+
+; CHECK-LABEL: define void @foo(
+
+; ONE: load i32, ptr %a0
+; ONE: load i32, ptr @g
+; ONE: extractelement <4 x ptr> <ptr @g, ptr null, ptr @g, ptr @g>, i32 11
+
+; ZERO: load i32, ptr null
+; ZERO: load i32, ptr null
+; ZERO: extractelement <4 x ptr> zeroinitializer, i32 11
+
+ at g = global i32 0
+
+define void @foo(ptr %a0) {
+  ; CHECK-INTERESTINGNESS: load i32
+  %v0 = load i32, ptr %a0
+  ; CHECK-INTERESTINGNESS: load i32
+  %v1 = load i32, ptr @g
+
+  ; CHECK-INTERESTINGNESS: extractelement{{.*}}i32 11
+  %v2 = extractelement <4 x ptr> <ptr @g, ptr null, ptr @g, ptr @g>, i32 11
+
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135307.465510.patch
Type: text/x-patch
Size: 2674 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221005/0a23d6a2/attachment.bin>