[PATCH] D135279: [SLP]Improve/fix CSE analysis of the blocks/instructions.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 5 11:58:09 PDT 2022
ABataev added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8715
}
+ if (auto *ExI = dyn_cast<Instruction>(Ex))
+ GatherShuffleExtractSeq.insert(ExI);
----------------
vdmitrie wrote:
> At this point Ex is guaranteed to be an instruction. So why dyn_cast?
Just want to be safe, remember some conflicts with possible ConstExprs as operands. I can change it to cast
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135279/new/
https://reviews.llvm.org/D135279
More information about the llvm-commits
mailing list