[PATCH] D133484: [AArch64][SVE] Fix AArch64_SVE_VectorCall calling convention

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

I don't understand what you mean by "exception of hoisting the work done inside LowerFormalArguments into LowerCall".  This is not something I requested is it? I mentioned passing `RVLocs` directly into `LowerCallResult` in place of the current `Ins` parameter because we shouldn't need to compute it twice. I've just tried this myself with your patch and see no issues.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:6761-6764
+    bool CalleeOutSVE = any_of(ArgLocs, HasSVERegLoc);
+    bool CalleeInSVE = any_of(RVLocs, HasSVERegLoc);
 
     if (CalleeInSVE || CalleeOutSVE)
----------------
You don't need the `Callee...` local variables anymore but I guess they don't hurt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133484/new/

https://reviews.llvm.org/D133484