[PATCH] D125782: [llvm-debuginfo-analyzer] 07 - Compare elements

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVCompare.h:75
+  }
+  LVPassTable getPassTable() const { return PassTable; }
+
----------------
CarlosAlbertoEnciso wrote:
> probinson wrote:
> > Returning a std::vector by value seems inefficient.
> Good point. Changed.
What about to add & after const in method declaration to make the method callable on lvalues only? If a method that returns a reference is callable on an rvalue ("temporary"), a returned reference can become dangling immediately after destroying the temporary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125782/new/

https://reviews.llvm.org/D125782