[PATCH] D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 07:36:46 PDT 2022


arsenm added a comment.

In D134854#3836573 <https://reviews.llvm.org/D134854#3836573>, @Pierre-vh wrote:

> I did some tries but I can't get a DAG combine to involve FMA/FMAD in DAGISel that's affected by this change (I tried both on AArch64 and AMDGPU). Any idea of how I can write such a test and what the expected output should be?
> The only combine I found involving this function only works if `-enable-no-signed-zeros-fp-math` is used

Then use "no-signed-zeros-fp-math"="true" in the test. That combine should also be updated to use nsz flags


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134854/new/

https://reviews.llvm.org/D134854



More information about the llvm-commits mailing list