[PATCH] D135266: [NFC][AMDGPULowerKernelAttributes] Factorize repeated code into function
Juan Manuel Martinez CaamaƱo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 5 07:34:38 PDT 2022
jmmartinez marked an inline comment as done.
jmmartinez added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:79
+ auto Intrinsic = IsV5OrAbove ? Intrinsic::amdgcn_implicitarg_ptr
+ : Intrinsic::amdgcn_dispatch_ptr;
+ StringRef Name = Intrinsic::getName(Intrinsic);
----------------
jdoerfert wrote:
> This is not a great variable name as it clashes with the class name, e.g., IntrinsicID
Changed to IntrinsicID
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135266/new/
https://reviews.llvm.org/D135266
More information about the llvm-commits
mailing list