[PATCH] D135261: [SimplifyLibCalls] Remove invalid code comment in optimizeStringLength. NFC

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope updated this revision to Diff 465387.
bjope added a comment.

Now just adjusting the code comment.

Description:

  [SimplifyLibCalls] Adjust code comment in optimizeStringLength. NFC
  
  The limitation in LibCallSimplifier::optimizeStringLength to only
  optimize when the string is an i8 array was changed already in
  commit 50ec0b5dceff1f3fe93 back in 2017.
  
  We still only simplify when 's 'points at an array of 'CharSize', so
  the comment is still valid in the sense that we do not support
  arbitrary array types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135261/new/

https://reviews.llvm.org/D135261

Files:
  llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp


Index: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
===================================================================
--- llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
+++ llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
@@ -926,9 +926,9 @@
   // strlen(s + x) to strlen(s) - x, when x is known to be in the range
   // [0, strlen(s)] or the string has a single null terminator '\0' at the end.
   // We only try to simplify strlen when the pointer s points to an array
-  // of i8. Otherwise, we would need to scale the offset x before doing the
-  // subtraction. This will make the optimization more complex, and it's not
-  // very useful because calling strlen for a pointer of other types is
+  // of CharSize elements. Otherwise, we would need to scale the offset x before
+  // doing the subtraction. This will make the optimization more complex, and
+  // it's not very useful because calling strlen for a pointer of other types is
   // very uncommon.
   if (GEPOperator *GEP = dyn_cast<GEPOperator>(Src)) {
     // TODO: Handle subobjects.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135261.465387.patch
Type: text/x-patch
Size: 1054 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221005/e46f420b/attachment.bin>