[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 07:03:40 PDT 2022


aaron.ballman added subscribers: zixuw, dexonsmith, gribozavr.
aaron.ballman added a comment.

In D134813#3836826 <https://reviews.llvm.org/D134813#3836826>, @sammccall wrote:

> I just landed that change to USR generation as 20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e <https://reviews.llvm.org/rG20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e>, so there should now be no USR changes (just some changes to debug representations that happen to be in some of the USR test files, which can be updated).

Thank you!

> I'd guess we need some kind of change to CommentXML and ExtractAPI, but I don't know enough to be sure what it should be.

Ping @dang @zixuw and @dexonsmith for questions about how to handle ExtractAPI changes, and @gribozavr for questions about CommentXML


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813



More information about the llvm-commits mailing list