[PATCH] D135266: [NFC][AMDGPULowerKernelAttributes] Factorize repeated code into function

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 06:58:56 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:79
+  auto Intrinsic = IsV5OrAbove ? Intrinsic::amdgcn_implicitarg_ptr
+                               : Intrinsic::amdgcn_dispatch_ptr;
+  StringRef Name = Intrinsic::getName(Intrinsic);
----------------
This is not a great variable name as it clashes with the class name, e.g., IntrinsicID


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135266/new/

https://reviews.llvm.org/D135266



More information about the llvm-commits mailing list