[PATCH] D135260: [AMDGPU][AMDGPULowerKernelAttributes] Use stripAndAccumulateConstantOffset

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:84
+  return M.getFunction(Name);
+}
+
----------------
jdoerfert wrote:
> jmmartinez wrote:
> > jdoerfert wrote:
> > > This function and uses are unrelated.
> > I'm sorry, I do not understand this remark. What do you mean?
> The commit is about the load tracking and stripping. This change (outlining getBasePtrIntrinsic and using it) is unrelated to the content/description of the patch. Make it two patches instead.
Oh! I agree. I created https://reviews.llvm.org/D135266 for that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135260/new/

https://reviews.llvm.org/D135260