[PATCH] D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 02:02:05 PDT 2022


ro added a comment.

This patch caused a regression on the  sanitizer-x86_64-linux-autoconf buildbot <https://lab.llvm.org/buildbot#builders/70/builds/28177> running a debug build:

  ThreadSanitizer-x86_64 :: Linux/check_memcpy.c

The executable now contains calls to `memset`.  AFAICS this is a consequence of changing debug builds from `-O1` to `-O0` and thus is expected.  Therefore I suggest to just add

  XFAIL: !compiler-rt-optimized

Unfortunately I missed this in my local builds: I had run `Debug` builds on `x86_64-pc-linux-gnu` both with a vanilla tree and my patch, but already the vanilla results were insanely bad (309 `FAILs`), so I didn't notice the regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91620/new/

https://reviews.llvm.org/D91620



More information about the llvm-commits mailing list