[PATCH] D135202: [IR] Add an opaque type to LLVM.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 01:10:37 PDT 2022


arichardson added inline comments.


================
Comment at: llvm/include/llvm/IR/DataLayout.h:678
+  case Type::OpaqueTyID:
     return TypeSize::Fixed(getPointerSizeInBits(0));
   case Type::PointerTyID:
----------------
Why is the size hardcoded to an as0 pointer? Wouldn't it make more sense to e.g. have the first type parameter define the underlying size?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135202/new/

https://reviews.llvm.org/D135202



More information about the llvm-commits mailing list