[PATCH] D121594: [VP] Add IR expansion for vp.icmp and vp.fcmp

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 00:11:36 PDT 2022


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:182
 
+  /// \brief Lower this VP comparison to a call to an unpredicated comparison.
+  Value *expandPredicationInComparison(IRBuilder<> &Builder,
----------------
craig.topper wrote:
> Do we need \brief on doxygen comments?  There are old patches like https://reviews.llvm.org/D46861 that removed them.
Yep, done as a follow up in rGa3a9b0743e31


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121594/new/

https://reviews.llvm.org/D121594



More information about the llvm-commits mailing list