[PATCH] D109213: [RegAllocFast] Clean-up. Remove redundant operations. NFC.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1169
       if (NeedToAssignLiveThroughs) {
-        DefOperandIndexes.clear();
+        SmallVector<uint16_t, 8> DefOperandIndexes;
         PhysRegUses.clear();
----------------
MatzeB wrote:
> arsenm wrote:
> > This now may require new reallocation for each call
> I would expect more than 8 def operands to be very rare so I wouldn't really worry about reallocations... That said I also don't know why moving the SmallVector around helps anything...
I agree, this is bad change. Originally I planned to add a support of statepoint instruction in the mode when it may have a lot of tied defs, And indeed this may require reallocation, so it is better to return this back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109213/new/

https://reviews.llvm.org/D109213