[PATCH] D132371: [DWARFLinker][NFC] Change interface of DWARFLinker to specify accel table kinds explicitly.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:756-761
+    // If we haven't decided on an accelerator table kind yet, we base ourselves
+    // on the DWARF we have seen so far.
+    if (AtLeastOneDwarfAccelTable && !AtLeastOneAppleAccelTable)
+      GeneralLinker.addAccelTableKind(DwarfLinkerAccelTableKind::DebugNames);
+    else
+      GeneralLinker.addAccelTableKind(DwarfLinkerAccelTableKind::Apple);
----------------
The original logic I tried to implement was to prefer the Dwarf debug names for Dwarf 5 and alter, and the Apple variant for anything before that. Can we retain that logic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132371/new/

https://reviews.llvm.org/D132371