[PATCH] D135196: [AArch64][Windows] Add llvm-readobj support for save_any_reg unwind opcode.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 16:13:36 PDT 2022


efriedma added a comment.

re: documentation, let's see what Microsoft says about your current patch.  I mean, I'm willing to help writing up, but only if they're actually interested in taking changes.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/arm64-unwind-save_any_reg.s:25
+//CHECK-NEXT:            0xe74882            ; ldp q8, q9, [sp, #32]
+//CHECK-NEXT:            0xe76689            ; ldp q6, q7, [sp], #160
+//CHECK-NEXT:            0xe3                ; nop
----------------
mstorsjo wrote:
> Would it be good to include cases with d registers and non-paired opcodes too?
I'm very confident the current testcase is correct because the decoded opcodes match what MSVC actually generates.  I'd be less confident about other testcases... but I can add some extra tests to ensure the decoding doesn't blow up, at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135196/new/

https://reviews.llvm.org/D135196



More information about the llvm-commits mailing list