[PATCH] D121594: [VP] Add IR expansion for vp.icmp and vp.fcmp
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 15:47:49 PDT 2022
craig.topper accepted this revision.
craig.topper added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:182
+ /// \brief Lower this VP comparison to a call to an unpredicated comparison.
+ Value *expandPredicationInComparison(IRBuilder<> &Builder,
----------------
Do we need \brief on doxygen comments? There are old patches like https://reviews.llvm.org/D46861 that removed them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121594/new/
https://reviews.llvm.org/D121594
More information about the llvm-commits
mailing list